Closed huxleyliau closed 10 months ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
ce881f5
) 68.59% compared to head (a6aac60
) 68.60%. Report is 1 commits behind head on main.:exclamation: Current head a6aac60 differs from pull request most recent head 4532209. Consider uploading reports for the commit 4532209 to get more accurate results
Files | Patch % | Lines |
---|---|---|
...pring/property/AutoUpdateConfigChangeListener.java | 83.33% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
recheck
What's the purpose of this PR
Implement parsing time based on pattern for @ApolloJsonValue from #49
Which issue(s) this PR fixes:
Fixes #49
Brief changelog
Make use of Gson's current way of turning a string into a date to make @ApolloJsonValue able to handle time strings according to a given pattern.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.