apolloconfig / apollo-java

Apollo Java Clients
Apache License 2.0
40 stars 72 forks source link

Implement parsing time based on pattern for @ApolloJsonValue #52

Closed huxleyliau closed 10 months ago

huxleyliau commented 10 months ago

What's the purpose of this PR

Implement parsing time based on pattern for @ApolloJsonValue from #49

Which issue(s) this PR fixes:

Fixes #49

Brief changelog

Make use of Gson's current way of turning a string into a date to make @ApolloJsonValue able to handle time strings according to a given pattern.

Follow this checklist to help us incorporate your contribution quickly and easily:

github-actions[bot] commented 10 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

huxleyliau commented 10 months ago

I have read the CLA Document and I hereby sign the CLA

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce881f5) 68.59% compared to head (a6aac60) 68.60%. Report is 1 commits behind head on main.

:exclamation: Current head a6aac60 differs from pull request most recent head 4532209. Consider uploading reports for the commit 4532209 to get more accurate results

Files Patch % Lines
...pring/property/AutoUpdateConfigChangeListener.java 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ============================================ + Coverage 68.59% 68.60% +0.01% Complexity 1206 1206 ============================================ Files 171 171 Lines 5196 5202 +6 Branches 561 562 +1 ============================================ + Hits 3564 3569 +5 Misses 1371 1371 - Partials 261 262 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nobodyiam commented 10 months ago

recheck