Closed nobodyiam closed 3 months ago
The recent changes enhance the synchronization validation logic within the ItemController
and NamespaceSyncModel
classes. The update
method now includes an additional validity check for synchronization to specific namespaces, improving error handling during update operations. A new method, syncToNamespacesValid
, has been added to NamespaceSyncModel
, ensuring synchronization criteria are thoroughly validated before proceeding.
File Path | Change Summary |
---|---|
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ItemController.java |
Enhanced update method to include a check for synchronization validity using model.syncToNamespacesValid(appId, namespaceName) . |
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/entity/model/NamespaceSyncModel.java |
Added syncToNamespacesValid method for validating synchronization against NamespaceIdentifier objects. |
In the code where bunnies hop,
Validations now wonβt stop!
Sync to namespaces, oh so bright,
Ensures our changes feel just right.
With every check, we leap and cheer,
Robust and ready, never fear! πβ¨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What's the purpose of this PR
add namespaces check in synchronization configuration feature
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit
New Features
Bug Fixes