search

apollographql / apollo-client

:rocket:  A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server.
https://apollographql.com/client
MIT License
19.34k stars 2.66k forks source link

Make useRenderGuard and profile work with React 19 #11795

Closed Tobbe closed 3 months ago

Tobbe commented 5 months ago

React 19 has changed the names of some internal variables. This PR updates the @apollo/client React integration to also support these new names.

The React changes were introduced here https://github.com/facebook/react/commit/f6131653570bbbf62d642ba9343b9cd0ab1ae97c

Also updating the version of @testing-library/react to a version that supports React 19. Support was introduced in https://github.com/testing-library/react-testing-library/releases/tag/v14.3.0

apollo-cla commented 5 months ago

@Tobbe: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

netlify[bot] commented 5 months ago

Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 951ff42c8cedcb6edcffe692873238fcc594798c
changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 951ff42c8cedcb6edcffe692873238fcc594798c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

phryneas commented 3 months ago

Thanks for the PR!

We found a way to do this without accessing React internals at all over in #11888, which is probably less flaky in the long run, so I'm going to close this :)