apollographql / meteor-integration

🚀 meteor add apollo
http://dev.apollodata.com/core/meteor.html
108 stars 45 forks source link

Fix tests #63

Closed xavxyz closed 7 years ago

xavxyz commented 7 years ago

Hey @lorensr, it's me again! 😄

This is a PR for #3.

tests ok

Tests run again by creating a package.json with the right dependencies, so we don't have to do Npm.depends in package.js

I also modified the server-side test as createApolloServer() doesn't return anything: the it works test create a graphql server with a basic schema, and then we run a query on it, expecting the data to be in the right shape. All credits goes to one of the graphql-server-express test for the inspiration 👍

There is still a warning output by checkNpmVersions in test mode, I tried to remove it by doing like explained here https://github.com/tmeasday/check-npm-versions/issues/7#issuecomment-262985313 but no luck.

What do you think?

Cheers :octocat:

lorensr commented 7 years ago

Thanks for the PRs Xavier 😊 Any ideas on this?

> apollo-meteor-integration@0.2.1 test /Users/me/gh/meteor-integration
> meteor test-packages ./ --driver-package practicalmeteor:mocha

[[[[[ Tests ]]]]]                             

=> Started proxy.                             
=> Started MongoDB.                           
/Users/me/.meteor/packages/ecmascript/.0.5.9.1yl34bv++os+web.browser+web.cordova/plugin.compile-ecmascript.os/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:190
      throw error;
      ^

TypeError: Cannot set property '/Users/me/gh/meteor-integration/node_modules/graphql-server-express/package.json' of undefined
    at Resolver._resolvePkgJsonMain (/tools/isobuild/resolver.js:320:9)
    at Resolver._resolve (/tools/isobuild/resolver.js:123:25)
    at /tools/isobuild/resolver.js:75:19
    at Entry._reallyRecompute (/Users/me/.meteor/packages/meteor-tool/.1.4.2_3.11ncx1r++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/optimism/lib/entry.js:215:26)
    at Entry._recomputeIfDirty (/Users/me/.meteor/packages/meteor-tool/.1.4.2_3.11ncx1r++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/optimism/lib/entry.js:179:17)
    at Entry.recompute (/Users/me/.meteor/packages/meteor-tool/.1.4.2_3.11ncx1r++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/optimism/lib/entry.js:46:20)
    at Resolver.optimistic [as resolve] (/Users/me/.meteor/packages/meteor-tool/.1.4.2_3.11ncx1r++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/optimism/lib/index.js:50:18)
    at ImportScanner._resolve (/tools/isobuild/import-scanner.js:466:36)
    at /tools/isobuild/import-scanner.js:499:29
    at _.each._.forEach (/Users/me/.meteor/packages/meteor-tool/.1.4.2_3.11ncx1r++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:87:22)
    at ImportScanner._scanFile (/tools/isobuild/import-scanner.js:498:5)
    at /tools/isobuild/import-scanner.js:344:14
    at Array.forEach (native)
    at ImportScanner.scanImports (/tools/isobuild/import-scanner.js:342:22)
    at /tools/isobuild/compiler-plugin.js:1040:17
    at Array.forEach (native)
    at Function.computeJsOutputFilesMap (/tools/isobuild/compiler-plugin.js:1008:19)
    at ServerTarget._emitResources (/tools/isobuild/bundler.js:1020:8)
    at /tools/isobuild/bundler.js:791:12
    at /tools/utils/buildmessage.js:359:18
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:352:34
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:350:23
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at Object.enterJob (/tools/utils/buildmessage.js:324:26)
    at ServerTarget.make (/tools/isobuild/bundler.js:782:18)
    at /tools/isobuild/bundler.js:2680:14
    at /tools/isobuild/bundler.js:2748:20
    at /tools/utils/buildmessage.js:271:13
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:264:29
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:262:18
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:253:23
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at Object.capture (/tools/utils/buildmessage.js:252:19)
    at bundle (/tools/isobuild/bundler.js:2633:31)
    at /tools/isobuild/bundler.js:2580:32
    at Object.withCache (/tools/fs/files.js:1601:12)
    at Object.exports.bundle (/tools/isobuild/bundler.js:2580:16)
    at /tools/runners/run-app.js:574:36
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at Object.enterJob (/tools/utils/buildmessage.js:324:26)
    at ServerTarget.make (/tools/isobuild/bundler.js:782:18)
    at /tools/isobuild/bundler.js:2680:14
    at /tools/isobuild/bundler.js:2748:20
    at /tools/utils/buildmessage.js:271:13
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:264:29
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:262:18
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at /tools/utils/buildmessage.js:253:23
    at [object Object].withValue (/tools/utils/fiber-helpers.js:89:14)
    at Object.capture (/tools/utils/buildmessage.js:252:19)
    at bundle (/tools/isobuild/bundler.js:2633:31)
    at /tools/isobuild/bundler.js:2580:32
    at Object.withCache (/tools/fs/files.js:1601:12)
    at Object.exports.bundle (/tools/isobuild/bundler.js:2580:16)
    at /tools/runners/run-app.js:574:36
    at Function.run (/tools/tool-env/profile.js:490:12)
    at bundleApp (/tools/runners/run-app.js:573:34)
    at AppRunner._runOnce (/tools/runners/run-app.js:617:35)
    at AppRunner._fiber (/tools/runners/run-app.js:876:28)
    at /tools/runners/run-app.js:403:12

npm ERR! Darwin 16.3.0
npm ERR! argv "/usr/local/Cellar/node/7.2.0/bin/node" "/usr/local/bin/npm" "run" "test"
npm ERR! node v7.2.0
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! apollo-meteor-integration@0.2.1 test: `meteor test-packages ./ --driver-package practicalmeteor:mocha`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the apollo-meteor-integration@0.2.1 test script 'meteor test-packages ./ --driver-package practicalmeteor:mocha'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the apollo-meteor-integration package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     meteor test-packages ./ --driver-package practicalmeteor:mocha
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs apollo-meteor-integration
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls apollo-meteor-integration
npm ERR! There is likely additional logging output above.
macbook:meteor-integration me$  git:(upstream ⚡ test) 1A m --version
Meteor 1.4.2.3
xavxyz commented 7 years ago

Mmmh, I was running the test with Node 6.

After updating to Node 7 (nvm.sh ftw), and doing npm install again it works for me. I'm also on Meteor 1.4.2.3.

lorensr commented 7 years ago

Works on fresh clone, thank you!