Open zionts opened 1 year ago
This ticket includes the product requirements, with the proposed Rover messaging. The text below is from that ticket. https://github.com/mdg-private/houston-product-design/issues/28
Conditions
Current behavior
rover subgraph check
error[E030]: This operation check has encountered 1 schema change that would break operations
from existing client traffic. The changes in the schema you proposed are incompatible
with graph my-graph@my-variant.
See https://www.apollographql.com/docs/studio/schema-checks/ for more information on
resolving operation check errors.
Expected behavior
rover subgraph check
We didn't detect any operations for your variant, so your operation checks failed.
If you are using this variant for development and don't want operation checks to run,
you can turn them off in the configuration page (link to variant's configuration page).
Conditions
Behavior
rover subgraph check
We didn't run operation checks since they're disabled for this variant. If you use this supergraph
variant in production, you should use operation checks to detect potentially
dangerous changes before they go to production.
Configure schema checks in Studio: (link to checks config page for the variant).
Champion customer asking for this too: https://graphchampions.slack.com/archives/C03QK0PMS01/p1670021179456389
Description
As a new feature of Apollo's schema checks, we are allowing operation checks to be configured as optional via variant-level settings in the checks configuration page. (see associated FE work in this PR and new API surface area in this monorepo PR)
This new setting will mean that the operations check task will be optional, and the
rover subgraph check
command will need to be updated to accommodate for that possibility. This has been a feature requested by users for two different reasonsSome users want operation checks to be less restrictive when there is no traffic (currently, it will fail on any potentially breaking change)
Acceptance Criteria
--build-only
)