apollographql / vscode-graphql

Apollo GraphQL VS Code extension
https://marketplace.visualstudio.com/items?itemName=apollographql.vscode-apollo
MIT License
68 stars 21 forks source link

Schema validation triggering in comments #118

Open kyldvs opened 1 year ago

kyldvs commented 1 year ago

With the latest update paren support was added (which is a change I love and helps a ton btw), and now it's triggering in the generated example comment from @graphql-codegen.

image

Is this expected? I do actually need to add a user field, so I can make this go away, but this extension probably shouldn't trigger in comments (or at least not comments in generated code).

alessbell commented 1 year ago

Hi @kyldvs, thanks for reporting this - I would also not expect that to error. I wrote a failing test, but I may not be able to come back to this for a week or two.

If anyone wants to pick this up in the meantime, it's up for grabs :)