Closed an-ky closed 8 years ago
Ohh my bad, first of all I overlooked that library_info.sections() can be used to check for existence of a specific section. Second I missed to add tests for the case. Do you think this is a valid change of the library_info? Then I will extent the tests, of course.
Seems to be a good addition. Please add tests and I'll merge your pull request.
Is this test appropriate? Sorry for spamming here, I'm overwhelmed by the grade git hub is automated. Awesome on one hand, confusing if one is not used to it.
Regards
Thanks! Everything is good!
Sometimes it is convenient to query a library for a specific section and expect an empty result if the section does not exists. This was not possible because library_info ASSERTed the section adresses thus crashing the Application if a section was not found. Fixed this by checking section begin and end and returning an emtpy vector of string if the section was not found.
It seems only affect pe_info.hpp, the other implementations seem to allow empty sections (or handle them differently altogether)