search

apostrophecms / sanitize-html

Clean up user-submitted HTML, preserving whitelisted elements and whitelisted attributes on a per-element basis. Built on htmlparser2 for speed and tolerance
MIT License
3.68k stars 349 forks source link

Not working under IE 11 #578

Closed CaptainJon closed 1 year ago

CaptainJon commented 1 year ago

which version should i download to be compatable with ie 11?

boutell commented 1 year ago

First, I thought I would ask why. Microsoft no longer supports Internet explorer 11 and has pushed it off desktops. The major corporations I work with as clients do not support Internet Explorer 11 anymore. I am not trying to be difficult, I am genuinely curious as to why you would need to do this at this point.

That being said, if you do have such a use case, you should be using babel to compile a version that is compatible with ES5. We don’t do that ourselves because we don’t use this module in the browser and are not in a position to support that well. It makes the most sense for you to have your own babel build for your own requirements.

On Fri, Nov 4, 2022 at 2:35 AM NeilChoi @.***> wrote:

which version should i download to be compatable with ie 11?

— Reply to this email directly, view it on GitHub https://github.com/apostrophecms/sanitize-html/issues/578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27LP4MTNJIY43R7VYLDWGSVC3ANCNFSM6AAAAAARW3VEPE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

arturs-buls commented 1 year ago

Don't know what was the case for original poster, but in my case - some Microsoft Office products launch WebView as IE, not Microsoft Edge. So applications that are supposed to run under Microsoft office should still support IE 11 for minority of their users (newer Microsoft office versions to use Microsoft Edge)

boutell commented 1 year ago

"Internet Explorer and Microsoft Edge Legacy are still used in Office Add-ins

Some combinations of platforms and Office versions, including volume-licensed perpetual versions through Office 2019, still use the webview controls that come with Internet Explorer 11 and Microsoft Edge Legacy (EdgeHTML-based) to host add-ins, as explained in this article. We recommend (but don't require) that you continue to support these combinations, at least in a minimal way, by providing users of your add-in a graceful failure message when your add-in is launched in these browsers."

Per Microsoft's recommendation, your best path here is to refuse to operate. Seriously, this is unsafe in so many other ways unrelated to sanitize-html. No one is maintaining it for security.

On Mon, Dec 19, 2022 at 5:08 AM Artur Buls @.***> wrote:

Don't know what was the case for original poster, but in my case - some Microsoft Office products launch WebView as IE, not Microsoft Edge. So applications that are supposed to run under Microsoft office should still support IE 11 for minority of their users (newer Microsoft office versions to use Microsoft Edge)

— Reply to this email directly, view it on GitHub https://github.com/apostrophecms/sanitize-html/issues/578#issuecomment-1357399803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27LW6F6DG2JJ7HDMDXDWOAXZPANCNFSM6AAAAAARW3VEPE . You are receiving this because you commented.Message ID: @.***>

--

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his