search

apotdevin / thunderhub

ThunderHub LND Lightning Node Manager in your Browser
https://www.thunderhub.io/
MIT License
418 stars 89 forks source link

Thunderhub does not create a "fresh/new" onchain address #534

Open thespielplatz opened 1 year ago

thespielplatz commented 1 year ago

Describe the problem/bug When creating a new onchain address via cli, this "new address" is also shown in thunderhub.

I don't know if this is really a bug, but in my case it lead to an account problem with another application, while rebalancing BTC via Boltz exchange.

Your environment

To Reproduce

  1. Create new onchain address via lncli Screenshot 2023-05-31 at 11 23 53

  2. Create new onchain address via Thunderhub Screenshot 2023-05-31 at 11 28 25

Expected behavior Thunderhub creates a new onchain address

Actual behavior Thunderhub shows the previous created address

tompro commented 3 weeks ago

Yes we ran into a similar issue (LND). From what I gathered in the newAddress RPC and rest the address type needs to be one of the NOT unused ones: image

A type prefixed UNUSED_ will result in one of the addresses that have already been generated but have not been used. With the other types it should always generate a fresh one. https://github.com/lightningnetwork/lnd/issues/8697