search

apparatus / fuge

The microservice shell
http://fuge.io
MIT License
431 stars 49 forks source link

add option to process to use SIGINT instead of SIGKILL #168

Open johnwebbcole opened 7 years ago

johnwebbcole commented 7 years ago

I have a process that spawns several ssh tunnels using shelljs.exec. The process will cleanup everything on SIGINT, but fuge is killing with SIGKILL, and you cannot open a handler on SIGKILL.

It wold be nice to have an option to set the kill signal on the process, that defaults to SIGKILL.

Looking over the runner code, it looks like it wouldn't be hard to add the option. I haven't looked at the option code yet so I don't know how hard adding those would be.

pelger commented 7 years ago

You would need to add the option to the fuge config project. Should be pretty simple, would be great if you could send me a PR on both repos!

johnwebbcole commented 6 years ago

Still using fuge a lot! And still would like to get this feature. The config side looks pretty easy, but the kill side has a wrapper that hard codes the signal, and the wrapper stop is used throughout. What's the preferred way to add parameters?