search

appc / spec

App Container Specification and Tooling (archived, see https://github.com/rkt/rkt/issues/4024)
Apache License 2.0
1.26k stars 146 forks source link

Update appc data structures for CRI #656

Closed squeed closed 8 years ago

squeed commented 8 years ago

@yifan-gu @lucab @s-urbaniak I also updated the appc spec for annotations, along with port forwards. Take a look and we can update glide to pull from appc/spec's CRI branch.

squeed commented 8 years ago

@yifan-gu this supersedes #655, with a slightly cleaner interface. Sorry for stepping on your toes.

lucab commented 8 years ago

For reference, this PR goes to a new cri branch which is aimed at being a playground and an early opportunity for reviewing changes related to supporting the new Kubernetes CRI runtime interface CRI includes a slightly different handling of pods and apps, and work is ongoing on the rkt side to support it. It looks fine to me, but I have no superpowers here.

squeed commented 8 years ago

We need to make progress on other parts of the CRI push, so I'm merging this, but we don't need to stop the discussion.

yifan-gu commented 8 years ago

@squeed We also need to add the same fields in the app level.

@squeed NVM, I saw them in the RuntimeApp.App...