search

appfeel / cordova-push-notifications

Phonegap, Cordova, Intel XDK push notifications support
MIT License
23 stars 25 forks source link

Does not work on iOS 8 Cordova 5.4.1 #4

Closed ShamimIslam closed 7 years ago

ShamimIslam commented 8 years ago

Love your plugin. Simplest of all the versions I've seen and it JUST WORKS.

Until I had to upgrade to Cordova 5.4.1.

Now I have 2 items:

1 item one is here:

cordova-push-notifications/PushPlugin.m:203:23: error: no visible @interface for 'UIView' declares the selector 'stringByEvaluatingJavaScriptFromString:' [self.webView stringByEvaluatingJavaScriptFromString:jsCallBack];

miqmago commented 7 years ago

Same as other issue, take a look on https://github.com/phonegap/phonegap-plugin-push

If you really think this is simpler, maybe we can take a look on how to update this plugin. But I really think that it does not make sense, having that there is an official mantained one.

ShamimIslam commented 7 years ago

Actually in my code review, the apfeel version was so much simpler. There just seemed some type changes from different veriosn of iOS and a few additional arguments that required defaults. Do we really need all the stuff in the new one? It seem so complex for something so simple - "remind me when something happens". The old one even had code samples for Windows 10 and the rest.

Do you know someone that has migrated to the new one? I don't want to break my build but XDK is deprecating 5.4.1.

On Wed, Nov 2, 2016 at 5:21 AM, Miquel notifications@github.com wrote:

Same as other issue, take a look on https://github.com/phonegap/ phonegap-plugin-push

If you really think this is simpler, maybe we can take a look on how to update this plugin. But I really think that it does not make sense, having that there is an official mantained one.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/appfeel/cordova-push-notifications/issues/4#issuecomment-257812030, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6oTqQpfNFzDbiGRIJDYh3Ud_dn4Sttks5q6FYWgaJpZM4J6KyN .