search

appfeel / cordova-push-notifications

Phonegap, Cordova, Intel XDK push notifications support
MIT License
23 stars 25 forks source link

Cordova 5.4.1 deprecated type generates 12 warnings #5

Closed ShamimIslam closed 7 years ago

ShamimIslam commented 8 years ago

Love your plugin. Fewest number of issues I've seen reported. It just works.

BUT: I am seeing the following 12 times and it will only get worse in Cordova 6.2.0 (next version)

Plugins/cordova-push-notifications/PushPlugin.m:137:61: warning: 'enabledRemoteNotificationTypes' is deprecated: first deprecated in iOS 8.0 - Please use -[UIApplication isRegisteredForRemoteNotifications], or -[UIApplication currentUserNotificationSettings] to retrieve user-enabled remote notification and user notification settings [-Wdeprecated-declarations] NSUInteger rntypes = [[UIApplication sharedApplication] enabledRemoteNotificationTypes]

Do not know if this is something you can control or not or what the right type should be.

miqmago commented 7 years ago

Well, this plugin is a little unmantained right now, as there is the official one in Phonegap: https://github.com/phonegap/phonegap-plugin-push

ShamimIslam commented 7 years ago

Yes and there area 100's of bells and whistles and 191 open issues and 8 pull requests active.

And yet the older one "just works" and would continue to "just work" if we could get the warnings to go away.

The code has not changed significantly between versions for the parts that are only in the older one. I looked. So why go with newer code that's buggy when older code just needs massaging.

If it ain't broke, don't fix it. The latest shiny shiny has a higher maintenance cost if i have to keep fixing things for different setups.

Are there advantages to the new one that I don't know of? I don't feel like redoing my entire exposure to the API in my current production app. And the old one "just worked".

On Wed, Nov 2, 2016 at 5:20 AM, Miquel notifications@github.com wrote:

Well, this plugin is a little unmantained right now, as there is the official one in Phonegap: https://github.com/phonegap/phonegap-plugin-push

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/appfeel/cordova-push-notifications/issues/5#issuecomment-257811747, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6oTnwaRXlRAs3qhob6vDuCTp6K3h1bks5q6FXGgaJpZM4J6K1R .

miqmago commented 7 years ago

Hmmm... ok thanks, you convinced me :) Will take a look, please, could you help me a little with it? I've been out of this repo too many time to fastly know what should be improved if there is something that does not work.

ShamimIslam commented 7 years ago

I'll have to go back through my repo - I started massaging a few different files - but then I ran out of time due to a deadline.

Now it's become more of an issue because I can't upgrade to XDK 3649 - they're really pushing me to get out of 5.4.1.

I'll have a look this week and at least name some files for you to look at.

On Wed, Nov 2, 2016 at 5:33 AM, Miquel notifications@github.com wrote:

Hmmm... ok thanks, you convinced me :) Will take a look, please, could you help me a little with it? I've been out of this repo too much time to fastly know what should be improved if there is something that does not work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/appfeel/cordova-push-notifications/issues/5#issuecomment-257814544, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6oTteS5Cga1OoApjuoUqcjn9xejVwRks5q6FjNgaJpZM4J6K1R .

miqmago commented 7 years ago

Comming soon, do not despair :)

miqmago commented 7 years ago

Right now it works (even there are still some warnings) Tested in ios 10 :)

ShamimIslam commented 7 years ago

Ok - but which version of Cordova are you running on? 5.4.1 works but I'm required to use 5.6 in the next version of the XDK and the one after that bumps me up to 6.x.

Thanks.

miqmago commented 7 years ago

cordova cli version: 6.4.0 (latest but does not affect to the plugin) cordova ios platform version: 4.3.1 (latest one, see https://github.com/apache/cordova-ios/releases)

ShamimIslam commented 7 years ago

Ok - I will try it out in the newer XDK with the updated Cordova.

On Thu, Dec 29, 2016 at 3:58 AM, Miquel notifications@github.com wrote:

cordova cli version: 6.4.0 (latest but does not affect to the plugin) cordova ios platform version: 4.3.1 (latest one, see https://github.com/apache/cordova-ios/releases)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/appfeel/cordova-push-notifications/issues/5#issuecomment-269600152, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6oTsDhLp_DPwx8dVHuKw9JEoQpPKhtks5rM3YqgaJpZM4J6K1R .