search

appfolio / gemsurance

Gem vulnerability checker using rubysec/ruby-advisory-db
MIT License
213 stars 24 forks source link

Fixed bug to run the tests #13

Closed bencolon closed 9 years ago

bencolon commented 9 years ago

Added "test-unit" gem development dependency.

jonkessler commented 9 years ago

Sorry.. why is this necessary? The tests run fine locally for me.

bencolon commented 9 years ago

I guess you've already test-unitgem installed in your local gemset. On master branch, try gem uninstall test-unit, then bundle install, then rake test:units ... bim 'require': cannot load such file -- test/unit (LoadError). Now same with this PR, tests are running fine ;)

jonkessler commented 9 years ago

Ruby 2.1.5 actually won't let me uninstall test-unit. [~/src/gems/gemsurance]$ gem uninstall test-unit
ERROR: While executing gem ... (Gem::InstallError) gem "test-unit" cannot be uninstalled because it is a default gem Are you on a different Ruby version?

bencolon commented 9 years ago

Right, I'm using 2.2.0. And it seems that Ruby 2.2 removed 'test-unit' from stdlib, so everything is normal from your and my side ;). What do you prefer ? Adding this test-unit gem dependency or a .ruby-version file (with 2.15) in the project ?

jonkessler commented 9 years ago

Ah, interesting. I'd be OK adding the dependency if it works in other ruby versions as well. I've actually been meaning to get travis set up for the repo. Let me look into that.

jonkessler commented 9 years ago

Thanks!