search

appfolio / gemsurance

Gem vulnerability checker using rubysec/ruby-advisory-db
MIT License
213 stars 24 forks source link

Modernise sample spec #29

Closed s01ipsist closed 7 years ago

jonkessler commented 7 years ago

Hi @s01ipsist! Since we don't use this style of test at my company, could you let me know more information about the change here? Was this changed in a recent Rails version?

s01ipsist commented 7 years ago

The expect syntax has been favoured over should for some time. http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/

The Rails.root call fails without loading the rails_helper, standard with rspec-rails.

The message was split into multiple lines to aid readability and meet Ruby style guide standards.

jonkessler commented 7 years ago

Awesome, thanks for explaining.