remove bohemia & global styles

coderabbitai[bot] commented 2 months ago

Walkthrough

This pull request introduces a series of changes across multiple components, focusing on layout modifications, styling updates, and the transition from SCSS variables to CSS custom properties. Key adjustments include restructuring form elements, enhancing visual feedback for user interactions, and consolidating styles to improve organization and maintainability. Several files have been removed or reorganized, reflecting a significant shift in how styles and themes are managed throughout the application.

Changes

File(s)	Change Summary
`app/components/account-settings/.../index.hbs`	Modified layout of personal token input form; wrapped `AkTextField` in a `<div>` for better flex usage and moved `AkButton` for streamlined structure.
`app/components/account-settings/security/multi-factor-auth/index.scss`	Added styles for anchor elements, including color and hover effects, enhancing visual feedback.
`app/components/ak-icon-button/index.scss`	Adjusted padding properties for small and medium icon buttons, removing redundant code for conciseness.
`app/components/ak-loader/index.scss`	Moved `stroke-linecap` property for better readability and removed unnecessary blank lines.
`app/components/ak-modal/index.scss`	Restructured CSS styles by nesting modal styles under a new global selector for improved organization.
`app/components/ak-table/index.scss`	Added `width: 100%` to table root and reorganized border properties for better readability.
`app/components/app-monitoring/details/index.scss`	Minor margin property adjustment for `.monitoring-toggle`, effectively no change in value.
`app/components/marketplace/plugin-card/index.hbs`	Restructured modal layout by adding a new container for improved organization without altering functionality.
`app/components/marketplace/plugin-card/index.scss`	Introduced new CSS class for modal content container, adding styles for anchor elements.
`app/components/notifications-page/.../index.scss`	Added a transparent background color to `.nf-unread-dot` and updated color for `.notification_unread_text`.
`app/components/partner/.../index.scss`	Multiple updates to color properties across various classes, adjusting from variables to specific hex values or more specific variables.
`app/styles/_color.scss`	Removed file containing color variables, indicating a change in color management strategy.
`app/styles/_component-variables.scss`	Updated color variables for various components, enhancing visual consistency.
`app/styles/_theme.scss`	Transitioned from SCSS variables to CSS custom properties for theming, adding a comprehensive set of new color variables.
`app/styles/_reset.scss`	Introduced a CSS reset file to normalize default styling across browsers.
`app/styles/app.scss`	Established a foundational stylesheet for the application, importing various styles and defining a z-index variable.
`ember-cli-build.js`	Updated SASS and CSS module configuration, changing paths and extensions.
`package.json`	Removed dependency on the Bohemia library, indicating a potential shift in the project’s dependencies.

Possibly related PRs

#1452: The changes in this PR involve restructuring the layout and styling of the multi-factor authentication component, which is closely related to the modifications made to the personal token input form in the main PR, as both involve adjustments to the layout and organization of components within the account settings.

Poem

🐰 In the garden where styles bloom,
A modal's dance dispels the gloom.
With colors bright and layouts neat,
The components now feel more complete.
A hop, a skip, a CSS cheer,
Our app shines bright, the changes here! 🌼

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 3a4aa6fbff41c017d0c27fe52bba9eae7f1ea978 and f3efcafeb8b409f329e47b6de06cc07e9f629831.

Files ignored due to path filters (1)

* `package-lock.json` is excluded by `!**/package-lock.json`

Files selected for processing (40)

* app/components/account-settings/developer-settings/personal-token-list/index.hbs (1 hunks) * app/components/account-settings/security/multi-factor-auth/index.scss (1 hunks) * app/components/ak-icon-button/index.scss (1 hunks) * app/components/ak-loader/index.scss (3 hunks) * app/components/ak-modal/index.scss (1 hunks) * app/components/ak-table/index.scss (2 hunks) * app/components/app-monitoring/details/index.scss (1 hunks) * app/components/marketplace/plugin-card/index.hbs (1 hunks) * app/components/marketplace/plugin-card/index.scss (1 hunks) * app/components/notifications-page/bell-icon/index.scss (1 hunks) * app/components/notifications-page/header/index.scss (1 hunks) * app/components/partner/client-info/styles.scss (1 hunks) * app/components/partner/client-project-list/item/index.scss (1 hunks) * app/components/partner/client-report-download/index.scss (1 hunks) * app/components/partner/client-report-download/report-password/index.scss (1 hunks) * app/components/partner/client-uploads-stat-chart/index.scss (4 hunks) * app/components/partner/clients-nav/index.scss (1 hunks) * app/components/partner/credit-transfer/credit-transfer-input/index.scss (2 hunks) * app/components/partner/export-stats/index.scss (1 hunks) * app/components/partner/invite-client/index.scss (1 hunks) * app/components/partner/partner-plan/index.scss (2 hunks) * app/components/partner/styles.scss (1 hunks) * app/styles/_color.scss (0 hunks) * app/styles/_component-variables.scss (12 hunks) * app/styles/_devices.scss (1 hunks) * app/styles/_form.scss (0 hunks) * app/styles/_global-styles.scss (1 hunks) * app/styles/_public-api.scss (1 hunks) * app/styles/_reset.scss (1 hunks) * app/styles/_theme-deprecated.scss (1 hunks) * app/styles/_theme.scss (1 hunks) * app/styles/_utils.scss (1 hunks) * app/styles/_vars.scss (0 hunks) * app/styles/app.sass (0 hunks) * app/styles/app.scss (1 hunks) * app/templates/authenticated/partner/client.hbs (1 hunks) * app/templates/authenticated/partner/project.hbs (1 hunks) * app/templates/loading.hbs (1 hunks) * ember-cli-build.js (1 hunks) * package.json (0 hunks)

Files not reviewed due to no reviewable changes (5)

* app/styles/_color.scss * app/styles/_form.scss * app/styles/_vars.scss * app/styles/app.sass * package.json

Files skipped from review as they are similar to previous changes (34)

* app/components/account-settings/developer-settings/personal-token-list/index.hbs * app/components/account-settings/security/multi-factor-auth/index.scss * app/components/ak-icon-button/index.scss * app/components/ak-loader/index.scss * app/components/ak-modal/index.scss * app/components/ak-table/index.scss * app/components/app-monitoring/details/index.scss * app/components/marketplace/plugin-card/index.hbs * app/components/marketplace/plugin-card/index.scss * app/components/notifications-page/bell-icon/index.scss * app/components/notifications-page/header/index.scss * app/components/partner/client-info/styles.scss * app/components/partner/client-project-list/item/index.scss * app/components/partner/client-report-download/index.scss * app/components/partner/client-report-download/report-password/index.scss * app/components/partner/client-uploads-stat-chart/index.scss * app/components/partner/clients-nav/index.scss * app/components/partner/credit-transfer/credit-transfer-input/index.scss * app/components/partner/export-stats/index.scss * app/components/partner/invite-client/index.scss * app/components/partner/partner-plan/index.scss * app/components/partner/styles.scss * app/styles/_component-variables.scss * app/styles/_devices.scss * app/styles/_global-styles.scss * app/styles/_public-api.scss * app/styles/_reset.scss * app/styles/_theme-deprecated.scss * app/styles/_utils.scss * app/styles/app.scss * app/templates/authenticated/partner/client.hbs * app/templates/authenticated/partner/project.hbs * app/templates/loading.hbs * ember-cli-build.js

Additional comments not posted (5)

app/styles/_theme.scss (5)
`1-4`: **Follow the guidelines mentioned in the comments.** The comments provide clear instructions on using the variables defined in this file and replacing any existing variables with these. Adhering to these guidelines will help maintain consistency and prevent the usage of deprecated variables throughout the codebase. --- `4-114`: **Excellent work on the new theme variable structure!** The transition from SCSS variables to CSS custom properties aligns with modern CSS practices and improves maintainability. The comprehensive set of variables, descriptive naming convention, and clear organization provide a centralized and consistent way to manage the application's theme. The new structure enhances readability and usability, making it easier for developers to understand and utilize the theme variables effectively. --- `23-24`: **The previous comment for this line range is still valid.** Please refer to the existing comment and address the placeholder for the `--success-dark` variable accordingly. --- `27-28`: **The previous comment for this line range is still valid.** Please refer to the existing comment and address the placeholder for the `--error-dark` variable accordingly. --- `117-120`: **The previous comment for this line range is still valid.** Please refer to the existing comment and address the deprecated `--neutral-white-100` variable accordingly.

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying irenestaging with Cloudflare Pages

Latest commit:	`f3efcaf`
Status:	✅ Deploy successful!
Preview URL:	https://5d64c12d.irenestaging.pages.dev
Branch Preview URL:	https://pd-1496-remove-bohemia-globa.irenestaging.pages.dev

View logs

cypress[bot] commented 2 months ago

Irene Run #474

Run Properties: Failed #474 • dc6b106446 ℹ️: Merge 188ad72cc3e57e87c68ea99e64fbf6fb7e4b93df into 29d5dcef3151b825d7b80731d48b...

Project	`Irene`
Branch Review	`PD-1496-remove-bohemia-global-styles`
Run status	`Failed #474`
Run duration	`07m 06s`
Commit	`dc6b106446 ℹ️: Merge 188ad72cc3e57e87c68ea99e64fbf6fb7e4b93df into 29d5dcef3151b825d7b80731d48b...`
Committer	`Sam David`
View all properties for this run ↗︎