fix analysis details css issues

coderabbitai[bot] commented 1 month ago

Walkthrough

This pull request introduces multiple modifications across various Handlebars and SCSS files related to the file comparison and vulnerability analysis components. The changes focus on enhancing the semantic structure and styling of the HTML elements, improving encapsulation within CSS, and refining the layout and presentation of vulnerability findings. New classes and variables are added, while existing classes are updated for better organization and readability, without altering the underlying logic or functionality of the components.

Changes

File Path	Change Summary
app/components/file-compare/analysis-details/index.hbs	Replaced `<span>` with `<div>`, updated class names, added `@spacing='1'` to `<AkStack>`.
app/components/file-compare/analysis-details/index.scss	Added styles for `.vulnerability-finding-container`, removed global styles for `.scrollable-box`, simplified `.analysis-static-content`.
app/components/file-compare/index.scss	Changed `top` property of `.file-compare-tabs` from `calc(200px - 0.5em)` to `calc(198px - 0.5em)`.
app/components/file-compare/vulnerability-details/index.scss	Changed `top` property of `.file-compare-vulnerability-details-header-wrapper` from `calc(200px - 0.5em)` to `calc(198px - 0.5em)`.
app/components/file-details/vulnerability-analysis-details/findings/code-box/index.scss	Removed `margin` from `.vulnerability-finding-container`, adjusted `h6` margin, defined `.clipboard-button` styles.
app/components/file-details/vulnerability-analysis-details/findings/code-box/index.ts	Added export for `FileDetailsVulnerabilityAnalysisDetailsFindingsCodeBoxComponent` in module registry.
app/components/file-details/vulnerability-analysis-details/findings/custom-vulnerabilities/index.hbs	Reformatted HTML for clarity, added `local-class='analysis-content-container'`.
app/components/file-details/vulnerability-analysis-details/findings/custom-vulnerabilities/index.scss	Reorganized CSS rules, introduced `.analysis-content-title` and `.analysis-content-container`.
app/components/file-details/vulnerability-analysis-details/findings/index.hbs	Added `local-class='analysis-content-container'` to component.
app/components/file-details/vulnerability-analysis-details/findings/index.scss	Removed border from `.analysis-section`, added `.analysis-content-title` and `.analysis-content-container`.
app/components/file-details/vulnerability-analysis-details/findings/vulnerable-api/index.hbs	Streamlined HTML structure, modified dynamic attribute binding, simplified rendering logic.
app/components/file-details/vulnerability-analysis-details/findings/vulnerable-api/index.ts	Updated `FileDetailsVulnerabilityAnalysisDetailsFindingsVulnerableApiSignature` interface, added `vulnerabilityDetails` computed property.
app/components/file-details/vulnerability-analysis-details/index.hbs	Restructured HTML, added new local classes for better layout management.
app/components/file-details/vulnerability-analysis-details/index.scss	Updated styles for `.analysis-details-header`, added new classes for layout and visual presentation.
app/styles/_component-variables.scss	Introduced new CSS variables for file compare analysis details.

Possibly related PRs

#1448: Enhancements in app/utils/parse-vulnerable-api-finding.ts improve vulnerability identification, linking to overall improvements in handling vulnerability findings.
#1453: Minor styling changes in app/components/file-compare/analysis-details/index.hbs align with the focus on semantic structure and styling improvements.
#1454: Updates in app/components/security/analysis-details/regulatory-categories/index.hbs enhance component flexibility, relating to overall user interface improvements.

Suggested reviewers

Yibaebi
Praseetha-KR
SmitGala
cosmosgenius

Poem

In the burrows deep, where the changes hop,
A new class here, a new style on top.
With divs and styles, we refine our way,
Making findings bright, come what may!
So let’s celebrate with a joyful cheer,
For the tweaks and turns that bring us near! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying irenestaging with Cloudflare Pages

Latest commit:	`6ef81c8`
Status:	✅ Deploy successful!
Preview URL:	https://f1a925b2.irenestaging.pages.dev
Branch Preview URL:	https://pd-1541-fix-analysis-details.irenestaging.pages.dev

View logs

cypress[bot] commented 1 month ago

Irene Run #488

Run Properties: Passed #488 • 7674768fd4 ℹ️: Merge f101b5c05a40139339805080f4e6ee99d60d3c53 into 2155055003e8937e91af519521d2...

Project	`Irene`
Run status	`Passed #488`
Run duration	`09m 41s`
Commit	`7674768fd4 ℹ️: Merge f101b5c05a40139339805080f4e6ee99d60d3c53 into 2155055003e8937e91af519521d2...`
Committer	`Sam David`
View all properties for this run ↗︎