modify breadcrumbs implementaion

coderabbitai[bot] commented 1 month ago

Walkthrough

This pull request introduces significant changes across various components related to breadcrumb navigation within the application. Key modifications include the integration of a new BreadcrumbsService for managing breadcrumb containers, updates to component logic for registering and unregistering these containers, and adjustments to rendering logic for breadcrumb items. Additionally, several components have been streamlined to enhance their interaction with the new service, while some modifier files have been removed as their functionality has been integrated into the main components.

Changes

File Path	Change Summary
app/components/ak-breadcrumbs/container/index.hbs	Removed `{{breadcrumbs-container id=this.id}}`, added `{{did-insert this.registerContainer}}`, moved `...attributes`.
app/components/ak-breadcrumbs/container/index.ts	Injected `BreadcrumbsService`, updated `AkBreadcrumbsContainerArgs`, added `registerContainer` method, overridden `willDestroy`.
app/components/ak-breadcrumbs/item/index.hbs	Simplified rendering logic with conditional checks for breadcrumb items.
app/components/ak-breadcrumbs/item/index.ts	Changed import to type import for `BreadcrumbsService`, added `isAppendable` property, added `initializeBreadcrumbsItem` method.
app/components/file-compare/index.ts	Injected `BreadcrumbsService`, updated `isAllUploadsBreadcrumb` getter.
app/components/file-compare/table/index.ts	Injected `BreadcrumbsService`, updated `handleComparisonClick` method.
app/components/file-compare/vulnerability-details/index.ts	Removed `RouterService`, injected `BreadcrumbsService`, updated referrer retrieval logic.
app/components/file-details/summary/index.hbs	Added `@query={{it.query}}` to `akm.listItem`.
app/components/file-details/summary/index.ts	Added optional `query` property to `FileMoreMenuItem` interface.
app/components/file-details/vulnerability-analysis-details/index.ts	Removed `RouterService`, injected `BreadcrumbsService`, updated referrer retrieval logic.
app/components/file-overview/header/index.hbs	Added `@query={{it.query}}` to `akm.listItem`.
app/components/file-overview/header/index.ts	Added optional `query` property to `FileMoreMenuItem` interface.
app/components/project-settings/header/index.ts	Updated service imports to type imports, added `router` and `bCS` services, modified breadcrumb logic.
app/controllers/authenticated/dashboard/project/settings/index.ts	Introduced `AuthenticatedDashboardProjectSettingsIndexController` with query parameters.
app/routes/authenticated/dashboard/project/settings/index.ts	Added `resetController` method for resetting controller properties.
app/services/breadcrumbs.ts	Removed `_containers` array, introduced single `container`, added `getPageReferrer` method, updated other methods accordingly.
app/modifiers/breadcrumbs-container.ts	Deleted: `BreadcrumbsContainerModifier` and associated interfaces.
app/modifiers/breadcrumbs-item.ts	Deleted: `BreadcrumbsItemModifier` and associated interfaces.

Possibly related PRs

#1448: The changes in the main PR involve modifications to the AkStack component and the BreadcrumbsService, which are related to the management of breadcrumb containers.
#1451: This PR focuses on enhancing testability in various components, including those related to breadcrumbs, suggesting a relationship in how these components are structured and tested.
#1466: The modifications in this PR involve changes to the structure and styling of analysis details, which may relate to how breadcrumb navigation is visually represented in the UI.

Suggested reviewers

future-pirate-king
SmitGala
Praseetha-KR
cosmosgenius

Poem

🐰 In the land of breadcrumbs, we hop and play,
New paths and containers brighten our day.
With services guiding, our trails intertwine,
Navigating through code, oh how we shine!
So here’s to the changes, both big and small,
A hop, skip, and jump, we celebrate all! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cypress[bot] commented 1 month ago

Irene Run #499

Run Properties: Failed #499 • f9caa03a18 ℹ️: Merge d3bc681fd36df327fa9d136439ac94c3e36126a5 into f77e133a6525b8a892bc5699af6b...

Project	`Irene`
Run status	`Failed #499`
Run duration	`10m 35s`
Commit	`f9caa03a18 ℹ️: Merge d3bc681fd36df327fa9d136439ac94c3e36126a5 into f77e133a6525b8a892bc5699af6b...`
Committer	`Yibaebi Elliot`
View all properties for this run ↗︎

Test results
Failures	`4`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`18`

Tests for review

ignore-vulnerability.spec.ts • 3 failed tests

View Output

Test		Artifacts
Ignore Vulnerability > It ignores vulnerability from Risk --> Risk (CRITERIA: "all future files") (RESET: for "Current File + All Future Files")		`Test Replay` `Screenshots`
Ignore Vulnerability > It ignores vulnerability from Risk --> Risk (CRITERIA: "all future files") (RESET: from Project Settings Page)		`Test Replay` `Screenshots`
Ignore Vulnerability > It ignores vulnerability from Risk --> Passed (CRITERIA: "all future files") (RESET: for "Current File Only")		`Test Replay` `Screenshots`

dynamic-scan.spec.ts • 1 failed test

View Output

Test		Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062		`Test Replay` `Screenshots`

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying irenestaging with Cloudflare Pages

Latest commit:	`4373071`
Status:	✅ Deploy successful!
Preview URL:	https://b7c5ee40.irenestaging.pages.dev
Branch Preview URL:	https://breadcrumbs-update.irenestaging.pages.dev