fix ember deprecations in store monitoring routes

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request introduces several changes across various components and models in the application. Key modifications include updates to type definitions, specifically changing the extra property in the AppMonitoringSettingsFilterSelectedItemArgs interface to enforce string values. Additionally, several @belongsTo relationships in the model classes have been updated to support asynchronous loading. Other changes involve altering how data is accessed and manipulated, particularly by replacing toArray() calls with slice() to create shallow copies of arrays.

Changes

File Path	Change Summary
app/components/app-monitoring/settings/filter-selected-item/index.ts	Updated `extra` property type in `AppMonitoringSettingsFilterSelectedItemArgs` from `Record<string, unknown>` to `Record<string, string>`. Modified `iconName` method to cast return value to `string`.
app/components/app-monitoring/settings/index.hbs	Changed `@selectedItemComponent` from static string to dynamic component invocation using `{{component}}` helper.
app/components/app-monitoring/table/index.ts	Updated `monitoringData` getter to return a shallow copy using `slice()` instead of `toArray()`.
app/components/app-monitoring/table/store-version/index.ts	Modified `fetchAmAppLatestVersions` to use `slice()` instead of `toArray()` for retrieving application versions.
app/components/app-monitoring/version-table/countries/index.ts	Changed `fetchAmAppVersionRecords` to retrieve records using `slice()` instead of `toArray()`.
app/components/app-monitoring/version-table/index.ts	Updated `fetchLiveAmAppVersions` to populate `storeVersionsToDisplay` with `slice()` instead of `toArray()`.
app/models/am-app-record.ts	Updated `@belongsTo` decorators for `amAppVersion`, `amAppSync`, and `amAppStoreInstance` to include `{ async: true }`.
app/models/am-app-store-instance.ts	Modified `@belongsTo` decorator for `amApp` property to include `{ async: true }`.
app/models/am-app-sync.ts	Updated `@belongsTo` decorator for `amApp` to include `{ async: true, inverse: 'lastSync' }`.
app/models/am-app-version.ts	Changed `@belongsTo` relationships for `amApp`, `uploadSubmission`, and `latestFile` to include `{ async: true }`.
app/models/am-app.ts	Updated multiple `@belongsTo` and `@hasMany` relationships to include `{ async: true }` for asynchronous handling.
app/models/amconfiguration.ts	Modified `@belongsTo` decorator for `organization` property to include `{ async: true }`.

Possibly related PRs

#1476: The main PR modifies the extra property type in the AppMonitoringSettingsFilterSelectedItemArgs interface, while this PR changes the way data is accessed in multiple components by replacing toArray() with slice(), indicating a similar focus on data handling methods.
#1480: This PR also modifies several components to replace toArray() with slice(), aligning with the main PR's emphasis on changing data retrieval methods for better handling.
#1481: Similar to the main PR, this PR updates the personalTokenList getter to use slice() instead of toArray(), reflecting a consistent approach to managing data structures across components.

Suggested reviewers

Praseetha-KR
cosmosgenius

Poem

🐰 In the garden of code, we hop and play,
With strings in our pockets, we brighten the day.
From arrays to slices, we dance with delight,
As async relationships take flight!
So here’s to our changes, both big and small,
A hop, skip, and jump—let’s code through it all! 🌼

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between fe850db0d9b512803414edba61f92f8ba73c38f4 and 06e958005488bd57f43e1770ce1e3d204ccdf44b.

📒 Files selected for processing (12)

* `app/components/app-monitoring/settings/filter-selected-item/index.ts` (2 hunks) * `app/components/app-monitoring/settings/index.hbs` (1 hunks) * `app/components/app-monitoring/table/index.ts` (1 hunks) * `app/components/app-monitoring/table/store-version/index.ts` (1 hunks) * `app/components/app-monitoring/version-table/countries/index.ts` (1 hunks) * `app/components/app-monitoring/version-table/index.ts` (1 hunks) * `app/models/am-app-record.ts` (1 hunks) * `app/models/am-app-store-instance.ts` (1 hunks) * `app/models/am-app-sync.ts` (1 hunks) * `app/models/am-app-version.ts` (1 hunks) * `app/models/am-app.ts` (1 hunks) * `app/models/amconfiguration.ts` (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (12)

* app/components/app-monitoring/settings/filter-selected-item/index.ts * app/components/app-monitoring/settings/index.hbs * app/components/app-monitoring/table/index.ts * app/components/app-monitoring/table/store-version/index.ts * app/components/app-monitoring/version-table/countries/index.ts * app/components/app-monitoring/version-table/index.ts * app/models/am-app-record.ts * app/models/am-app-store-instance.ts * app/models/am-app-sync.ts * app/models/am-app-version.ts * app/models/am-app.ts * app/models/amconfiguration.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cloudflare-workers-and-pages[bot] commented 3 weeks ago

Deploying irenestaging with Cloudflare Pages

Latest commit:	`06e9580`
Status:	✅ Deploy successful!
Preview URL:	https://35b563d6.irenestaging.pages.dev
Branch Preview URL:	https://pd-1557-ember-5-upgrade-fix.irenestaging.pages.dev

View logs

cypress[bot] commented 3 weeks ago

Irene Run #516

Run Properties: Passed #516 • df374d0988 ℹ️: Merge 01286b2dc898a61bbc2dc34faba45986774cea9a into 11c3dbc41c5e19e0d2b82f989239...

Project	`Irene`
Branch Review	`PD-1557-ember-5-upgrade-fix-deprecation-in-store-monitoring-routes`
Run status	`Passed #516`
Run duration	`05m 14s`
Commit	`df374d0988 ℹ️: Merge 01286b2dc898a61bbc2dc34faba45986774cea9a into 11c3dbc41c5e19e0d2b82f989239...`
Committer	`Yibaebi Elliot`
View all properties for this run ↗︎