apple / pfl-research

Simulation framework for accelerating research in Private Federated Learning
http://apple.github.io/pfl-research/
Apache License 2.0
281 stars 27 forks source link

Need faster bisection when calculating privacy parameters #86

Open grananqvist opened 1 month ago

grananqvist commented 1 month ago

bisection in https://github.com/apple/pfl-research/blob/develop/pfl/privacy/privacy_accountant.py#L431 is currently slow. The UX running the CIFAR10 notebook interactively is bad. Looks like it gets stuck initializing PLDPrivacyAccountant , but it just takes ~30sec.

Something like Brent’s method or golden section can be used to speed up initialization of moments accountants that must use bisection to find the right epsilon.

(120412225)