Update Wycheproof ecdh_secp384r1_test.json to v1 - Githubissues

apple / swift-crypto

Open-source implementation of a substantial portion of the API of Apple CryptoKit suitable for use on Linux platforms.

https://apple.github.io/swift-crypto

Apache License 2.0

1.47k stars 165 forks source link

Update Wycheproof ecdh_secp384r1_test.json to v1 #162

Closed Sajjon closed 1 year ago

Sajjon commented 1 year ago

Update Wycheproof testvector ecdh_secp384r1_test v0 to ecdh_secp384r1_test v1.

Checklist

[x] I've run tests to see all new and existing tests pass
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

If you've made changes to `gyb` files

[ ] I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

We ought to use as many and as up to date test vectors as possible. Wycheproofs v0 were created 4 years ago and were due some upgrade.

Modifications:

Replaced the v0 with the v1 version.
Changed fatalError in test code with a failable init (same change as in https://github.com/apple/swift-crypto/pull/160)

Result:

Number of tests is now 1047 instead of v0's test count of ~319~.

Lukasa commented 1 year ago

@swift-server-bot test this please