search

apple / swift-distributed-actors

Peer-to-peer cluster implementation for Swift Distributed Actors
https://apple.github.io/swift-distributed-actors/
Apache License 2.0
607 stars 61 forks source link

Consider renaming node.systemName #147

Open ktoso opened 5 years ago

ktoso commented 5 years ago

Discussion https://github.com/apple/swift-distributed-actors/pull/112#discussion_r326903899

Neither are generated. Picking something like "shortName" might be ok here or "label" perhaps... We use them in first@12.3.4:999/user/path/actor and they are useful for human readable names fist/second or "us-west-1991" etc. We do NOT enforce them all have to be the same in a cluster -- unlike akka, where the name has to be the same for all nodes in the "same cluster", so there it is more of a "actor system name" since by system we like to talk about "all the nodes" 🤔 The same name thing is too restrictive and does not really help in real world, so we lifted that in swift. But we might also want to change the name then...

Short name is kind of what erlang calls them; there one can use "short names" or "full names -- which are IPs", though short names are only for local mode I believe.

I'm thinking shortName or name or label?

akbashev commented 1 year ago

While fixing https://github.com/apple/swift-distributed-actors/issues/1141 I've realised systemName is actually not so important, so probably makes sense to rename. If we compare shortName vs. label from first glance not sure what shortName should mean, but label is short and descriptive.