Closed czechboy0 closed 1 year ago
@swift-server-bot add to allowlist
Thanks for the review, @ktoso, will address your feedback!
@ktoso, ok I commented out the strict concurrency flags for now, but I think taking these changes would still be valuable. Once we have an answer for making withSpan
safe, we can just uncomment the flags.
It's a good change over all, I'll give it another skim and merge. Thank you @czechboy0 !
Related radars: rdar://113846321 rdar://113848512
Looks good, thank you @czechboy0 !
And we'll follow up on those radars about strict checking and closures
Summary
To help avoid concurrency bugs, this PR enables complete concurrency checking mode and addresses all the current concurrency warnings.
Some notable changes:
stdout
/stderr
(which emitted a warning, as it's a read-write global variable), usingfdopen
, which I think should be fine, but calling it out./scripts/validate_format.sh
, so might be worth reviewing the diff with?w=1
Test Plan
Tested that all builds and tests pass on macOS and Linux.