apple / swift-distributed-tracing

Instrumentation library for Swift server applications
https://swiftpackageindex.com/apple/swift-distributed-tracing/main/documentation/tracing
Apache License 2.0
222 stars 30 forks source link

Enable strict concurrency checking in CI #132

Closed czechboy0 closed 1 year ago

czechboy0 commented 1 year ago

Summary

To help avoid concurrency bugs, this PR enables complete concurrency checking mode and addresses all the current concurrency warnings.

Some notable changes:

Test Plan

Tested that all builds and tests pass on macOS and Linux.

tomerd commented 1 year ago

@swift-server-bot add to allowlist

czechboy0 commented 1 year ago

Thanks for the review, @ktoso, will address your feedback!

czechboy0 commented 1 year ago

@ktoso, ok I commented out the strict concurrency flags for now, but I think taking these changes would still be valuable. Once we have an answer for making withSpan safe, we can just uncomment the flags.

ktoso commented 1 year ago

It's a good change over all, I'll give it another skim and merge. Thank you @czechboy0 !

Related radars: rdar://113846321 rdar://113848512

ktoso commented 1 year ago

Looks good, thank you @czechboy0 !

And we'll follow up on those radars about strict checking and closures