search

application-research / delta

Filecoin deal proposal / making service
Apache License 2.0
16 stars 4 forks source link

Delta does not appear to respect environment vars by default #116

Closed Zorlin closed 1 year ago

Zorlin commented 1 year ago

Describe the bug Delta doesn't appear to actually respond to the env vars I'm passing it

OS: linux
--
2023-04-29 7:34:29 pm | Architecture: amd64
2023-04-29 7:34:29 pm | Hostname: testcustomer-delta-0
2023-04-29 7:34:29 pm | Starting Delta daemon...
2023-04-29 7:34:29 pm | Setting up the whypfs node...
2023-04-29 7:34:29 pm | repo: .whypfs
2023-04-29 7:34:29 pm | walletDir: ./wallet_estuary
2023-04-29 7:34:29 pm | mode: cluster

I'm setting repo and wallet dir, but not passing them as CLI flags, and it doesn't respect them, they should be

  config.env: >
    # Node info

    NODE_NAME=delta-node

    NODE_DESCRIPTION=Experimental Deal Maker

    NODE_TYPE=delta-main

    REPO=/storage/whypfs

    DELTA_WALLET_DIR=/storage/wallet

    # Database configuration

    MODE=cluster

    DB_NAME=deltadb

    DB_DSN=postgres://delta:REDACTED@delta.dbfws.customer-testcustomer/deltadb

Delta Info Latest Delta as of this post, running in k8s

alvin-reyes commented 1 year ago

This should be fixed on the latest commit. Please re-open if that's not the case.