appsignal / appsignal-nodejs

🟩 AppSignal for Node.js
https://www.appsignal.com/nodejs/
MIT License
28 stars 9 forks source link

Add Pino support to the logger #828

Open unflxw opened 1 year ago

unflxw commented 1 year ago

Like Winston (see #821) Pino also supports transports, so we can probably tie it into the logging API in a similar way.

In the Intercom thread from #821., the customer mentioned Pino would also be interesting to have.

To do

backlog-helper[bot] commented 1 year ago

:heavy_check_mark: All good!

New issue guide | Backlog management | Rules | Feedback

tombruijn commented 1 year ago

@unflxw can you add a section with a To do list that describes in detail the steps someone has to take to complete this issue?

backlog-helper[bot] commented 1 year ago

This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.

If a blog post is not required, please add the [skip blogpost] tag next time, and close the created issue.

backlog-helper[bot] commented 1 year ago

This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.

If a blog post is not required, please add the [skip blogpost] tag next time, and close the created issue.

luismiramirez commented 1 year ago

Moving this to backlog until we're able to log via HTTP.

Pino transports are run as worker threads. We can't pass the client safely as an argument to the worker initialization, and as we're using TS, making users write a built file path is not an ideal solution.

pantajoe commented 1 year ago

Would also be interesting for my company, we just started using Appsignal and we'd love to move our logging to Appsignal.

unflxw commented 1 year ago

Thanks @pantajoe! We may take another look at this issue soon. In the meantime, note that we do support Winston.

shairyar commented 11 months ago

https://app.intercom.com/a/inbox/yzor8gyw/inbox/admin/4356044/conversation/16410700256468?view=List (private link)

mgm1313 commented 1 week ago

Is this still being considered? Since the start of this thread, Pino has grown closer to Winston in terms of adoption and is still faster than Winston, which is why we prefer it in our stack.

pino,winston

I found this transporter in user land https://github.com/duailibe/pino-appsignal-transport, but official support would still be awesome! :)

luismiramirez commented 3 days ago

@mgm1313 hey, thank you!

Yes, we're considering this and we're moving it ahead soon.