appsignal / opentelemetry-instrumentation-bullmq

OTel Auto-instrumentation for BullMQ
Apache License 2.0
4 stars 3 forks source link

Tweak "producer as parent" config option #12

Closed unflxw closed 1 month ago

unflxw commented 1 month ago

Some minor tweaks to the changes introduced in #11. See #10 for context.

Rename the config option to useProducerSpanAsConsumerParent (that is, s/Context/Span) to use language that is more familiar to casual OpenTelemetry users.

Rewrite the config option description to describe what happens with and without the config option.

Rearrange the instrumentation to move logic branches out of the span creation function.

[ping @Steffen911, in case you're using a pre-release version, note the config option name has been changed!]

backlog-helper[bot] commented 1 month ago

Hi @unflxw,

We've found some issues with your Pull Request.


New issue guide | Backlog management | Rules | Feedback