search

appsignal / probes-rs

Rust library to read out system stats from a machine running Unix
MIT License
15 stars 2 forks source link

Disk stats, refactoring and renames #20

Closed thijsc closed 8 years ago

thijsc commented 8 years ago

Pretty big airplane pull. I implemented disk stats in a slightly nicer way than some of the other probes. I've then refactored the other ones to bring them in line with this structure.

thijsc commented 8 years ago

I've opensourced the repo and added Travis configuration. Trying to get a green build in this pull.

thijsc commented 8 years ago

There is something wonky going on with the values returned by process memory metrics. I think maybe Docker related? Will look into it. In the mean time this is ready for general review.

timonv commented 8 years ago

Cool! Have fun at Railsconf!

All the Measurement structs look awefully familiar, apart fromt there being singular an plural variants. Maybe it's an idea to make it a generic struct? I can imagine that might be useful when using the library higher up.

thijsc commented 8 years ago

I was trying to do that, but could not find a way where it's actually less code. Do take a stab at it if you like :-).

thijsc commented 8 years ago

Yay, green build

matsimitsu commented 8 years ago

:cake: