appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
32.27k stars 3.49k forks source link

[Feature]: Add CockroachDB support #14369

Open angel-urena opened 2 years ago

angel-urena commented 2 years ago

Is there an existing issue for this?

Summary

Add a plugin for using a CockroachDB database as a datasource in Appsmith.

Why should this be worked on?

CockroachDB is a distributed SQL database built by Cockroach Labs. We use this database at Movatic and we're currently evaluating Appsmith to build internal tools. While so far it looks like we're able to get by using the PostgresSQL plugin since it is for the most part compatible with CockroachDB, it would be much better to have a first-party integration to be able to fully take advantage of all the features. For example, it is currently not possible to fetch the structure of a CockroachDB database using the PostgreSQL integration because the query that is run to get all the schema information that is not compatible with it.

At the moment this is not a blocker for us but I thought it would be a good idea to propose this integration anyway since CockroachDB is awesome and it would be nice if Appsmith fully supported it eventually.

Nikhil-Nandagopal commented 2 years ago

@angel-urena thanks for the feature request! I'm not sure when we'll be able to get to this but if we see a lot more requests for this, we'll try to prioritise it

kiwioverseas commented 2 years ago

Full CockroachDB support would be great!

giladv commented 1 year ago

supporting cockroach only means supporting a connection string / connection options

kishaningithub commented 1 year ago

@angel-urena How were you able to connect to cockroach db? From what i see cockroach serverless requires us to pass the "options" parameter which inturn contains the cluster identifier

@giladv As you said if they just allow direct postgres connection string to be passed then this problem is solved in my opinion

ashwinassysh commented 1 year ago

@Nikhil-Nandagopal Is this development getting prioritized? I need want to integrate my cockroach DB instance with Appsmith. @kishaningithub Were you able to figure out how to connect to appsmith using the plugin mentioned by @angel-urena?

Nikhil-Nandagopal commented 1 year ago

@ashwinassysh unfortunately this hasn't been prioritized yet

semiautomatix commented 1 year ago

😞

kishaningithub commented 1 year ago

@Nikhil-Nandagopal Can one pay appsimithorg money to get this to the topmost priority? If yes, where do i pay?

ashwinassysh commented 1 year ago

@Nikhil-Nandagopal Please get this prioritized.

hoducha commented 9 months ago

👍 CockroachDB serverless is a great complement to Appsmith.

xgp commented 4 months ago

+1 for this. Since we migrated our DB to CRDB, it means we can't use Appsmith anymore :cry:

FYI, I looked in https://github.com/appsmithorg/appsmith/blob/release/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java and the Postgres plugin doesn't use any Postgres-specific features that Cockroach doesn't support. I.e. reading from the pg_catalog and pg_constraint table are supported in CRDB.

Like the others have suggested, I think this might be as simple as allowing a direct override of the JDBC_URL here or allowing the query parameters to be specified in the Postgres plugin setup UI, and then appending them when the JDBC_URL is being built here.

Is there some documentation about getting a dev setup running? I can definitely update and test the Java, but I don't know how/where to update the UI and test it locally. If I can get some guidance, I'm happy to do this.

emperorkebab commented 3 weeks ago

+1