appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.35k stars 3.72k forks source link

[Bug]: Currency Input widget issues #14835

Open shadabbuchh opened 2 years ago

shadabbuchh commented 2 years ago

Is there an existing issue for this?

Description

When user changes the Decimals back to 0, the value does not automatically round off rather the user has to click inside the widget for the value to round off. https://www.loom.com/share/3257dda3e9b4459a9bf8f49a9bfa280c

Steps To Reproduce

  1. D&D a Currency Input widget.
  2. Set the Decimals to 2.
  3. Enter any value with decimals.
  4. Now change the Decimals value back to 0.

Notice that the value does not automatically round off to the nearest number. The user has to click inside the widget in order to round off the value.

Public Sample App

No response

Version

Cloud

Front logo Front conversations

github-actions[bot] commented 2 years ago

We have found issues that are potential duplicates:

codedmind commented 2 years ago

Any update on this?

dilippitchika commented 2 years ago

Hey @codedmind this is a low priority item on our plate and I don't think we will get to it anytime soon. Why is this important for you?

codedmind commented 2 years ago

@dilippitchika one of our apps have a lot of currency widgets and we are not able to input decimals values... so this have a high impact in our end. Are this difficult to solve? Otherwise we must redo the app and replace the currency widget...

dilippitchika commented 2 years ago

@codedmind this is a different issue, i believe you are talking about this issue - https://github.com/appsmithorg/appsmith/issues/14261 - where the decimal separator is not working in EU countries as expected.

This current issue is a different issue, which only happens in the edit mode and has no impact on view mode

codedmind commented 2 years ago

@dilippitchika your are correct! My mistake ... any news regarding that issue :D

dilippitchika commented 2 years ago

We have figured out a solution, but are stuck in terms of scaling that. Could you help us with the details of how your users use currencies, do all of them follow a single style for entering decimals like . or based on the country they are located in they change the way they write decimals?

codedmind commented 2 years ago

@dilippitchika yes they all use the same way... in our case the decimal is the comma

PrasadMadine commented 3 months ago

Hi @shadabbuchh , I'm picking this issue.

PrasadMadine commented 3 months ago

Hi @shadabbuchh , the selected decimals are not being reflected even on clicking inside the widget, as contrary to the description mentioned. I have implemented reflecting decimal values when clicking inside the widget i.e., onFocus, or the value should be reflected when the decimals changed. Share your input over hear.