search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.9k stars 3.66k forks source link

[Task]: Icon position should be hidden when no icon is selected #24068

Open aswathkk opened 1 year ago

aswathkk commented 1 year ago

Is there an existing issue for this?

SubTasks

image

The visibility of the position segment should be hidden when no icons are selected.

Created from https://github.com/appsmithorg/appsmith/pull/18533#issuecomment-1576580848

Faizan711 commented 1 year ago

is this issue still open and needs work? if so then I would like to get assigned and fix it.

rohitagarwal88 commented 1 year ago

@Faizan711 You can work on the issue. I have assigned it to you.

Faizan711 commented 1 year ago

Thanks for assigning, just wanted to know this issue is in client side or server side of app, and should i ask queries on discord?

rohitagarwal88 commented 1 year ago

@Faizan711 : feel free to ask all queries on github relevant to the issue.

Faizan711 commented 1 year ago

Thanks a lot, As I was going through the repo, i saw it has two parts client and server so this issue is on which part? and also the setup for this locally seemed a bit complex, if you could tell me in short it would be great.

Sheikh-JamirAlam commented 1 year ago

@Faizan711 This looks like an issue on the client side code. As for the setup, check these links - Github instructions You'll see Youtube video links there as well on the "Running the Client" and "Running the Server" page.

Faizan711 commented 1 year ago

Thanks a lot. I will go through these

Vishrut19 commented 1 year ago

Hey @Faizan711 are you working on this issue?

Faizan711 commented 1 year ago

Yes

pheonix-18 commented 1 year ago

@Faizan711 are you still working on it?

Faizan711 commented 1 year ago

Sorry mate, I can't work on it now Please assign it to somebody else

iSatVeerSingh commented 1 year ago

@aswathkk @pheonix-18 I want to work on this. You can assign me.

Vishrut19 commented 1 year ago

I have already asked to work on it since very long time.

pheonix-18 commented 1 year ago

@iSatVeerSingh Please go ahead. I can ask for an update in the next 2 days. Thanks

Vishrut19 commented 1 year ago

Hey @pheonix-18 what about the part where I asked to work on the same ?

iSatVeerSingh commented 1 year ago

@Vishrut19 You can work on this. Just start working on this, there is no need to assign. You can check the PR for reference. It will be helpful.

Vishrut19 commented 1 year ago

Sure No problem and also we can collaborate on it if you want

pheonix-18 commented 1 year ago

Hey @pheonix-18 what about the part where I asked to work on the same ?

hey @Vishrut19 , can you elaborate on what you are talking about?

I see that PR by @iSatVeerSingh is working. I will look into this issue if it is not merged.

iSatVeerSingh commented 1 year ago

@pheonix-18 if @Vishrut19 wants to work on this, he can. You can ignore my PR.

Vishrut19 commented 1 year ago

@pheonix-18 if @Vishrut19 wanted to work on this, he can. You can ignore my PR.

No no. @pheonix-18 can move ahead with @iSatVeerSingh's PR

pheonix-18 commented 1 year ago

@Vishrut19 , I'm not a maintainer of this project, So I can't merge Satveer's PR. At the moment, I'm confused with what you are saying.

  1. Are you asking me to work on this issue?
  2. Do you want to work on it by ignoring Satveer's PR?
Vishrut19 commented 1 year ago

Nop actually what I am trying to say is that we can move forward with @iSatVeerSingh's PR. I can work on another issue.

NIKHILNAIR21 commented 1 year ago

is this issue still open and needs work? if so then I would like to get assigned and fix it.

abhisheksharma010 commented 1 year ago

Hello, I would like to work on this, can it be assigned to me

Ashwini-reactdev commented 1 year ago

Hi @rohitagarwal88 , assign this to me, Thank You!

rishabhpassi commented 1 year ago

Hi , @aswathkk is this still open. I think I could solve this one! Please Assign me !

AndBeeHaus commented 1 year ago

Hello, I'd like to work on it. @aswathkk could you please assign this to me?

harshlakhara commented 8 months ago

Hello, I'd like to work on this issue. @aswathkk can you assign this to me?

git-sumana commented 7 months ago

<!DOCTYPE html>

Hide Icon Position
Icon Position:

try this!

akshat8605 commented 5 months ago

Is this issue still open? Can it be assigned to me?

Uriyo commented 4 months ago

is this issue still open?

Harshithazemoso commented 4 months ago

Hello @aswathkk,

I have identified that the issue exists in the Button, ButtonGroup(simple and Menu items) and JSONForm widgets. I managed to resolve it for the two widgets. However, in the JSONForm widget, the icon names for the "submit" and "reset" buttons are showing as "undefined," even though the icons are present for both buttons. We are unable to determine where this "undefined" value is being passed from. so, is it okay to create a new bug, that only targets Button, ButtonGroup, MenuButton,

and let this bug remain for JSONForm widgets

or we can create a new one for JSNFormWidgets.

I am working on the implemenation, I will keep you posted about the pull request.Thank you

akshayvijayjain commented 3 months ago

@aswathkk we have a pull request open for this issue https://github.com/appsmithorg/appsmith/pull/33794

Hello @aswathkk,

I have identified that the issue exists in the Button, ButtonGroup(simple and Menu items) and JSONForm widgets. I managed to resolve it for the two widgets. However, in the JSONForm widget, the icon names for the "submit" and "reset" buttons are showing as "undefined," even though the icons are present for both buttons. We are unable to determine where this "undefined" value is being passed from. so, is it okay to create a new bug, that only targets Button, ButtonGroup, MenuButton,

and let this bug remain for JSONForm widgets

or we can create a new one for JSNFormWidgets.

I am working on the implemenation, I will keep you posted about the pull request.Thank you

Please give us feedback on how to proceed ahead with the ticket

@rohitagarwal88

Suvrajit69 commented 3 months ago

@rohitagarwal88 Is this issue solved?? I did love to work on this issue.

akshayvijayjain commented 3 months ago

@rohitagarwal88 Is this issue solved?? I did love to work on this issue.

bug remains for JSONForm widgets, you can explore!

Suvrajit69 commented 3 months ago

@akshayvijayjain @aswathkk Cannot find this page in website. Please tell me on which page this issue exists in live website?

akshayvijayjain commented 3 months ago

@Suvrajit69 Please check this thread you should get your answer https://github.com/appsmithorg/appsmith/pull/18533#issuecomment-1576580848

Please set up local development environment and try to find the relevance in the code.

Suvrajit69 commented 3 months ago

@akshayvijayjain thank you very much. I got the issue. Can you please assign me this issue please ?

akshayjai1 commented 3 months ago

@Suvrajit69 .

You want to work on Json FormWidget part?

@Harshithazemoso has raised pr for the other parts .

I am not a maintainer in the project.

I think you can create Pr and raise.

I don't understand the assignee part here as people are free to work or not work on it

Suvrajit69 commented 3 months ago

@akshayvijayjain I want to contribute the position button only for now.

riodeuno commented 3 months ago

As noticed in @Harshithazemoso 's PR, the APIs currently available, make the solution to behave incorrectly. Unfortunately, we won't be able to immediately prioritise a fix for this API. As a result, we're removing the "Good First Issue" tag from this issue for now.

Suvrajit69 commented 3 months ago

@riodeuno hello are you still want to fix this issue? if yes then tell me . I want to give it a try.