search

appsody / controller

Appsody controller running in the development container. This repo will be archived soon.
https://appsody.dev
Apache License 2.0
2 stars 12 forks source link

extend APPSODY_IGNORE_DIRS to also include files #36

Open kewegner opened 5 years ago

kewegner commented 5 years ago

Currently the APPSODY_IGNORE_DIRS allows specifying the full path to a file, but the name of the variable, and documentation does not state this.

kewegner commented 4 years ago

I think the question here is should we rename (via deprecation) the environment variable to APPSODY_IGNORE_PATHS @neeraj-laad do you have an opinion?

kewegner commented 4 years ago

I think what we need to do is something like this:

  1. Document the new variable APPSODY_IGNORE_PATHS

//tmpWATCHIGNOREDIR is set first

appsodyIgnorePaths = os.Getenv("APPSODY_IGNORE_PATHS") if appsodyIgnorePaths != "" { tmpWATCHIGNOREDIR=appsodyIgnorePaths }

So if both are available appsodyIgnorePaths wins.