Open mateo-meillon opened 1 year ago
Seems like there's a few other bugs with regards to updating user preferences.
Update
button stays disabled.X
icon for the first preference gets rid of all the preferences for that user (only in the UI), and the Update
button stays disabled in this case as well. I've tried attaching screen caps to demonstrate this.
P.S. GitHub video previews have always been weird for me. If it seems like nothing is happening in the videos, just scroll back to the start and it'll work.
Even though I deleted them from bottom to top in this preview, it doesn't have to be done that way in this case.
I'd love to work on this issue and create a PR. Let me know if possible!
It seems like a really simple fix to be honest.
@Maettis thanks for raising this! 🙏🏼
@safwanyp this might have been fixed already, but let me double check with the team.
@safwanyp looks like it hasn't. Assigned!
@stnguyen90 Great, thanks!
@stnguyen90 pinging to inform you that i just made the PR.
Thank you, our team will review your PR as soon as possible.
Update: There seems to be also the case for whitespaces. Using " " (spaces) for both key and value allows saving the preferences.
https://github.com/appwrite/appwrite/assets/20625965/2a894283-8b18-4904-aa4c-8041759d32c9
Not sure, why we can not update the preference via console... may be this might be related to this itself?
Preferences are typed internally, but using the console to change them converters them all to strings. Type-column in the table is needed, it's not a case of "if the comment get enough votes". This can break stuff!
Dangrous stuff:
false
is really set to "false"
which is considered true
in javascript10
is really set to "10"
which might crash some calculation
👟 Reproduction steps
When I go to a authed user-> /console//auth/user- and remove an remove an preference, the update button does not become active and I cannot save the changed, but when adding one and deleting another, then saving -> it works. I only tested it by deleting 1/1 preference
👍 Expected behavior
It should delete the preference for the user
👎 Actual Behavior
It did nothing -> proof when reloading
🎲 Appwrite version
Version 1.2.x
💻 Operating system
Linux
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?