search

april / certainly-something

WebExtension that shows certificate chains in an aesthetically pleasing manner.
https://addons.mozilla.org/en-US/firefox/addon/certainly-something/
Mozilla Public License 2.0
91 stars 20 forks source link

[WIP] Support "uploading" a cert chain #52

Closed ghost closed 5 years ago

ghost commented 5 years ago

I have added basic html file and context menu for upload certificate. Please let me know if this is ok and what are next steps like on submit event and design of page.

april commented 5 years ago

The layout of the page can always be worked on later, the next steps will be for it to take that uploaded file, parse the certificate, and pass it into the normal code that is used to display the certificate viewer. :)

ghost commented 5 years ago

Can you give me the example of certificate file and have confusion, on refresh uploaded certificate will be removed?

april commented 5 years ago

Any certificate chain in PEM format should do, as that is most likely what someone would upload.

ghost commented 5 years ago

Do I need to post or store that certificate otherwise on refresh it will get deleted.

april commented 5 years ago

I don't think it's necessary to store it. If we decided we wanted to do that, we could always make a different issue for it.

ghost commented 5 years ago

The function parse which you have used converts the rawDER into PEM. But in upload certificate it is already in PEM. So why to parse that certificate?

april commented 5 years ago

If it's already in PEM, then you wouldn't need to parse it that way. :)

april commented 5 years ago

This was completed in dd43a1e3488c29e488742690b3a3fd6711304103.