Hide credentials form after logging in

aquiladev / remix-mythx-plugin

The plugin allows executing security check via MythX in Remix IDE

http://remythx.xyz

MIT License

16 stars 14 forks source link

Hide credentials form after logging in #11

Closed Gtonizuka closed 5 years ago

Gtonizuka commented 5 years ago

After clicking on “save”, credentials address and password still stays there and there is no user feedback that let the user know if the login worked correctly or not. We should have a message that says "logged in correctly" and then hide that form. The user should still be able to re-open that form to log in with a different user or logout.

aquiladev commented 5 years ago

right now login executes each request to MythX, that is why I used button Save for user credentials, not Login. User has a message about wrong credentials when he presses Analyze button.

It is possible to store JWT in local storage after the first login, it will slightly more complicated to handle

aquiladev commented 5 years ago

in scope of https://github.com/aquiladev/remix-mythx-plugin/pull/22 I implemented collapsing/expanding of credentials block

aquiladev commented 5 years ago

request to add the text “hide” next to icon V

Annotation 2019-07-15 162243

Annotation 2019-07-15 162300