search

aragon / aragon-network-token

Smart contracts for the Aragon Network Token
https://aragon.network
GNU General Public License v3.0
117 stars 40 forks source link

Implement Multi Minter #38

Closed izqui closed 3 years ago

izqui commented 3 years ago

Implements a Multi Minter contract which after being set as the minter for ANT, will allow for different contracts to mint ANT.

This is necessary to allow contracts that will automatically mint ANT (the two different contracts for the ANJ merge conversion) as well as allowing for future arbitrary or automatic minting by the Aragon Network DAO

nivida commented 3 years ago

Thanks for opening this PR Jorge! What do you think about having a max amount of allowed tokens minted per registered minter? It would reduce the risk if something unexpected would go wrong with a contract minter.

izqui commented 3 years ago

As replied in the forum:

I don’t think that really solves anything. If the minter is broken and someone abuses it, there will be a problem regardless as those who still haven’t converted wouldn’t be able to convert. Minters should be absolutely secure anyway, and the contract itself could impose such limit if necessary (in this case, that’s implicitly the total supply of ANJ)