aralroca / next-translate-plugin

Next-translate plugin for i18n in Next.js 🌍 - Load page translations and use them in an easy way!
MIT License
30 stars 17 forks source link

fix: use the symbol from the node when present #66

Closed danielpid closed 1 year ago

danielpid commented 1 year ago

Related with https://github.com/aralroca/next-translate-plugin/issues/8 https://github.com/aralroca/next-translate/issues/1116

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [X] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) The function that gets the symbol for node. If we already have a symbol, we use it, otherwise we try to get the symbol as before.

Which issue (if any) does this pull request address? When there's a custom app (_app), the getInitialProps wasn't called.

Is there anything you'd like reviewers to focus on? I'm not familiar with the Typescript Compiler API, but the change seems reasonable. I tried the basic example from next-ranslate and seems to be working fine.