aramis-lab / clinica

Software platform for clinical neuroimaging studies
http://www.clinica.run/
Other
227 stars 81 forks source link

Noisy and useless summary when specifying a list of subjects manually #249

Open ghisvail opened 3 years ago

ghisvail commented 3 years ago

Describe the bug I get a summary of the subjects not found in the BIDS folder despite manually specifying a list of subjects via the -sl / --subjects-list option. If there is anything useful to report in this case, it's the absence of specific subjects from the manually specified list in the target BIDS folder, instead of the whole list found in the clinical data. It yields an unecessary amount of noise to the end of the logs, especially when the dataset features a lot of participants such as ADNI.

To Reproduce Steps to reproduce the behavior:

Expected behavior If the desired $SUBJECT_ID is found in the target BIDS folder, then nothing. If the desired $SUBJECT_ID is not found in the target BIDS, then report it.

AliceJoubert commented 1 month ago

Still the case for ADNI and OASIS datasets since both use create_participants_df from bids_utils. To discuss :