arana-db / arana

Arana is a Cloud Native Database Proxy. It can also be deployed as a Database mesh sidecar.
http://arana-docs.rtfd.io/
Apache License 2.0
292 stars 92 forks source link

fix: optimize show open tables xxx statment (#676) #825

Closed gufengwyx8 closed 7 months ago

gufengwyx8 commented 9 months ago

What this PR does: optimize show open tables xxx statment

Which issue(s) this PR fixes: Fixes #676

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cr-gpt[bot] commented 9 months ago

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt[bot] commented 9 months ago

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9b24ed9) 40.20% compared to head (aa7f09e) 40.20%.

Files Patch % Lines
pkg/runtime/plan/dal/show_open_tables.go 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #825 +/- ## ======================================= Coverage 40.20% 40.20% ======================================= Files 265 265 Lines 26708 26708 ======================================= Hits 10738 10738 + Misses 14826 14823 -3 - Partials 1144 1147 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cr-gpt[bot] commented 7 months ago

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt[bot] commented 7 months ago

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

baerwang commented 7 months ago

把comment 都resolve下吧 @gufengwyx8