search

arcadelab / deepdrr

Code for "DeepDRR: A Catalyst for Machine Learning in Fluoroscopy-guided Procedures". https://arxiv.org/abs/1803.08606
GNU General Public License v3.0
209 stars 60 forks source link

Image vanishes when threads are increased #32

Open maxrohleder opened 3 years ago

maxrohleder commented 3 years ago

When changing the number of threads in the Projector instantiation, parts of the projection images vanish as can be seen in the screenshot. Nothing else was changed in the creation of these two images except the threads parameter (from 8 to 10).

Does anyone have an idea what the problem could be? Will post updates if I find out myself.

thread_issue

mathiasunberath commented 3 years ago

Problem seems to be somewhere after L215 in https://github.com/arcadelab/deepdrr/blob/main/deepdrr/projector/projector.py when multiple blocks are being looped over. This is a functionality we have not tested much if at all. Because the projection of the initial block is similar to the the one with default values, it's either because the other blocks are never projected, the other blocks are projected but the projections not merged, or their spatial positioning is wrong. This is something we'll have to look at but not sure how high a priority this is for us at this moment. So if you do want to look into this, that would be highly appreciated.

maxrohleder commented 3 years ago

I will let you know when I find out. Also not so much a priority for me atm. Just wanted to add this to record :)