search

archtechx / tenancy

Automatic multi-tenancy for Laravel. No code changes needed.
https://tenancyforlaravel.com
MIT License
3.68k stars 434 forks source link

Fix: Seed Job Failing To Run Due to `confirmToProceed` Condition In Seed Command #1265

Closed andyleach closed 1 month ago

andyleach commented 1 month ago

During our work with the package, we were attempting to create a new tenant via a artisan command we created. We noticed that when we shifted to production it would hang and never complete, but only while the environment was set to production. While digging into this, we noticed that it was getting caught here:

https://github.com/archtechx/tenancy/blob/3.x/src/Commands/Seed.php#L49

To resolve this, we added the force option when invoking the seed command from the job that AFAIK is only run upon standing up a tenant. Not really sure when or why this behavior changed considering the blame says it's unchanged for years, so I can only assume it was a change in Laravel because we've used this package for years now without encountering this issue.

Side note, thanks for all the work you do on this!

stancl commented 1 month ago

It should work to just configure the args here (see the commented out --force): https://github.com/archtechx/tenancy/blob/30cdc9461e1a120834e8cdee39aef7a9ced9f863/assets/config.php#L195-L198

It's disabled by default for safety reasons but if you know you do want to use tenants:seed (even indirectly), you can just uncomment the line included for this.