arcnmx / MPD

MPD fork adding a youtube-dl plugin
https://github.com/MusicPlayerDaemon/MPD/pull/223
GNU General Public License v2.0
7 stars 2 forks source link

yajl unexpected eof error #22

Closed arcnmx closed 4 years ago

arcnmx commented 4 years ago

When youtube-dl fails it typically prints an error message to stderr, then exits with a failure code. When this happens stdout is empty, so yajl errors out with an unexpected EOF parse error.

(I have no strong opinions either way but both items seem reasonable enough - though reading stderr seems a little annoying and maybe unnecessary)

Rio6 commented 4 years ago

I think it'd be nice to see error message from youtbe-dl, or at least a message indicating that youtube-dl failed. But that's probably not a high priority right now.

arcnmx commented 4 years ago

It might be nice to capture the stderr message, but yeah agreeing that's pretty low priority for now. It's not unusual to check mpd's logs for more details when something goes wrong anyway.