search

arcticicestudio / styled-modern-normalize

modern-normalize.css for styled-components
http://npm.im/styled-modern-normalize
MIT License
18 stars 1 forks source link

Update to latest version #4

Closed azdanov closed 5 years ago

azdanov commented 6 years ago

There is a modern-normalize.css version 0.5.0. And styled-components version 4.1.1 for peer dependency.

Would a PR be welcome with a version bump?

arcticicestudio commented 6 years ago

That would be great :+1: I've also added it to my TODOs, but the list is actually to long and there are more urgent tasks. If you'd like to submit a PR please take care of all changes made since v0.4.0 (maybe one commit per change for better overview in logs?) and replace styled-components deprecated (v3) injectGlobal function with the really nice and new createglobalstyle component factory function introduced in v4. I think the docs should not mention both functions for something like legacy or backwards compatibility since there should be absolute no reason why someone might stay on v3. Also the official styled-components docs provide a migration guide that explains how to update so this is covered.

arcticicestudio commented 5 years ago

Resolved in #5