ardatan / graphql-tools

:wrench: Utility library for GraphQL to build, stitch and mock GraphQL schemas in the SDL-first approach
https://www.graphql-tools.com
MIT License
5.35k stars 818 forks source link

perf: Assume internally created schemas as valid #6629

Closed aarne closed 3 weeks ago

aarne commented 3 weeks ago

Description

Sets assumeValid to true when creating new GraphqlSchema in stitchSchemas.

Im not 100% sure if this is really safe to do so, but the perf implications are non negligible. So if we cannot just assume the schema to be valid at this stage then we can hopefully at least leave this for the user to decide somehow?

Type of change

How Has This Been Tested?

Internal releases.

Test Environment:

Checklist:

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: d10ed7bc500515069afcb296862fd0e312f12d6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ------------------------- | ----- | | @graphql-tools/stitch | Minor | | @graphql-tools/federation | Patch | | federation-benchmark | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ardatan commented 3 weeks ago

Thanks!