ardovic / Open-Source-Android-Weather-App

☔️ Open source android weather app. See "Issues" tab for current tasks queue. Tasks suitable for beginners are labeled with green "beginner friendly" tags.
https://www.ardovic.com
MIT License
104 stars 81 forks source link

Credits "Activity" required #20

Closed ardovic closed 5 years ago

ardovic commented 6 years ago

We need a nice easy-to-update Activity with credits list, where everyone who had contributed to the project will be listed.

This activity will be accessed from navigation menu.

At first, the list will be manually edited. Later we should connect it to projects github API (it should be possible), this way the list will be updated each time a new contributor appears.

yskwon1231 commented 6 years ago

I'd like to work on this issue if it is okay. Can I work on it?

ardovic commented 6 years ago

Hi, yes of course. I was unable to assign you here on GitHub, because your name didn't appear in the list, but it is normal, consider yourself assigned onto this issue.

If you get stuck, feel free to ask here at any time. Good luck!

yskwon1231 commented 6 years ago

I've been working on this issue by making fragments that appear when items in navigation menu are clicked. But items in navigation menu does not react to the click.
I can't find a way to solve this problem. Can somebody give me some help?

ardovic commented 6 years ago

please make a commit into your fork and make request to dev branch of the original project with recent changes and write here, I'll check and see what's the problem.

ardovic commented 6 years ago

Your changes have been added to the project successfully! Since you've contributed to the project, you've gained the right of being a member of Android OSC (Open Source Community) - check your invitation here: https://github.com/android-osc.

Important: If you want to make the badge on your profile page visible by others, make sure to change your "Membership" status to "Public"

rajBopche commented 5 years ago

Please close this issue if resolved @ardovic @yskwon1231