ardovic / Open-Source-Android-Weather-App

☔️ Open source android weather app. See "Issues" tab for current tasks queue. Tasks suitable for beginners are labeled with green "beginner friendly" tags.

https://www.ardovic.com

MIT License

104 stars 81 forks source link

#47 : reduced the boiler-plate for providing context using @BindsInstance a… #48

Closed rajBopche closed 5 years ago

rajBopche commented 5 years ago

…nd @Component.Builder and removed no-args constructor for App Module

Description

This changes not only reduce unnecessary code but also provides performance optimization.

Fixes #(issue)

47

Type of change

Just put an x in the [] which are valid.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

[ ] ./gradlew assembleDebug assembleRelease
[ ] ./gradlew build connectedCheck

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[x ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x ] My changes generate no new warnings