search

arduino-libraries / Ethernet

Ethernet Library for Arduino
http://arduino.cc/
259 stars 264 forks source link

Add DHCP hostname option #77

Open shoop opened 6 years ago

shoop commented 6 years ago

Updated version of PR #50 as well as arduino/Arduino#5701. Code taken from mykh/ArduinoEthernetLibrary@3625ad990fd02572876193af532e70524ed5e8c8 , lightly edited to apply to current master. Not intended to take credit, just wanted to contribute.

greyltc commented 4 years ago

Can anyone say why seemingly great PRs like this never get merged or even commented on by the maintainers here?

PaulStoffregen commented 4 years ago

Except for very small edits, the reality is nobody is currently maintaining this library. I was maintaining it a couple years ago, which led to the 2.0.0 release. But since then I became very busy working on Teensy 4.0 (which pays my bills... work on this library is unpaid, so please understand every minute I've spent on Ethernet has been funded by Teensy sales). I intended to get back to Ethernet later this year or maybe in 2021. That may still happen. But right now I am extremely busy with a very long list of features people want on Teensy 4. FWIW, one of those features is the built-in ethernet hardware, which has bus master DMA and TCP/IP acceleration hardware.

Arduino also changed their policies, now requiring 2FA for access to any of their repositories. I have not yet set that up on my account. It's on a very long list of lower-priority things I'm too busy to worry about right now. So I no longer have access to commit to this library, even if I did have the time to do so.

Maybe someone else will start maintaining this library? It's an unpaid and mostly thankless job. The Arduino developers also tend to be cautious, so building enough trust to be allowed to maintain such a widely used library takes time.

I wish I had a better answer for you. But hopefully an honest answer is better than a "nice" one?

greyltc commented 4 years ago

Thanks for taking the time to respond and also for your volunteer efforts to make the library better for all of us! I'm struggling to understand why you're not (and seemingly nobody is) getting paid to maintain this library. This library drives sales. Why wouldn't the entity behind the Arduino brand spend the money to at least review and integrate features the community is adding for free to their products? Today it feels like they're rejecting free labor from qualified contributors in the community.

JAndrassy commented 4 years ago

it is very risky to change something in so widely used multiplatform library supporting 3 chip versions on many different shield and modules. For the 2.0.0 version Paul did tests which may took longer then to make the changes in the code,

Misiu commented 4 years ago

@per1234 @Rotzbua maybe this can be merged instead of #50?

Misiu commented 4 years ago

@shoop any chances you might look into this? 🙂

shoop commented 4 years ago

hi @Rotzbua , thank you for the review.

I don't pretend that my C code is very good, but I tried to address all your comments. I chose to break backwards compatibility in the interface because (as seen in the example) I find the consuming version better with the MAC, HOSTNAME order before the optional timeout arguments. But if you would like to be backwards compatible I can try and do another version.

Note this is still only very lightly tested.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.