arduino-libraries / Ethernet

Ethernet Library for Arduino
http://arduino.cc/
259 stars 264 forks source link

Add Spresense Support for Ethernet lib #91

Closed kamtom480 closed 3 years ago

PaulStoffregen commented 5 years ago

Why is such an invasive patch (so many changes in W5100Class::write and W5100Class::read) needed for this board?

kamtom480 commented 5 years ago

For Spresense board chip select is controlled by hardware. By sending data using SPI before each transfer, the chip select changes to a low state, and when it ends, it changes to high. To avoid changing the chip select state to high when sending a frame, a block of data is sent instead of sending bytes one at a time. This patch does not change anything for other boards.

PaulStoffregen commented 5 years ago

If that's the case, then this board will be incompatible with nearly all Arduino libraries using SPI.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.