search

arduino / arduino-examples

Arduino IDE bundled examples
Creative Commons Zero v1.0 Universal
90 stars 41 forks source link

Enable `pulseIn()` sketches for Portenta in sketch compilation workflow #45

Closed per1234 closed 3 years ago

per1234 commented 3 years ago

At the time the "Compile Examples" CI workflow was written, the Portenta H7 board did not have a pulseIn() function. Although this was a legitimate bug, since this was an issue with the arduino/ArduinoCore-mbed code base, already tracked there (https://github.com/arduino/ArduinoCore-mbed/issues/48), and unrelated to the code hosted in this repository, it was determined that the best approach would be to configure the workflow to not compile the examples that used pulseIn() for the Portenta H7.

Since that time, pulseIn() has been implemented for Portenta H7 (https://github.com/arduino/ArduinoCore-mbed/commit/f5ddfa85431fa7ae391118cbb48c986687dba497) and so we can now compile these sketches for that board.