arendst / Tasmota

Alternative firmware for ESP8266 and ESP32 based devices with easy configuration using webUI, OTA updates, automation using timers or rules, expandability and entirely local control over MQTT, HTTP, Serial or KNX. Full documentation at
https://tasmota.github.io/docs
GNU General Public License v3.0
22.27k stars 4.81k forks source link

ESP32 : Manage File system : Download function seems to be broken #17709

Closed Noschvie closed 1 year ago

Noschvie commented 1 year ago

PROBLEM DESCRIPTION

A clear and concise description of what the problem is. The file download at the "Manage File system" web interface seems to lead to a broken filename.

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

- [ ] If using rules, provide the output of this command: `Backlog Rule1; Rule2; Rule3`:
```lua
  Rules output here:


### TO REPRODUCE
_Steps to reproduce the behavior:_
Got to "Manage File system" and try to download a file from the list, the filename will be fragmented.

### EXPECTED BEHAVIOUR
_A clear and concise description of what you expected to happen._

### SCREENSHOTS
_If applicable, add screenshots to help explain your problem._
The file script.txt is the selected file to be download.

![grafik](https://user-images.githubusercontent.com/48217146/212544969-5f60c62e-efbd-4f8e-9095-36c8d4440247.png)

![grafik](https://user-images.githubusercontent.com/48217146/212545453-ba4aa06b-83a4-4c70-abfb-71eb0740f29e.png)

![grafik](https://user-images.githubusercontent.com/48217146/212545531-7bbcb55d-a167-4973-af82-d922124937a1.png)

### ADDITIONAL CONTEXT
_Add any other context about the problem here._
Tested with Firefox and Chrome

**(Please, remember to close the issue when the problem has been addressed)**
s-hadinger commented 1 year ago

I rarely use file download but I already saw similar behavior. To be investigated

barbudor commented 1 year ago

Looking with Chrome dev-tools, trying to download a file named "test_simple.stl" I see: image

currently adding more logs to track

barbudor commented 1 year ago

definitively some bad memory management in the `donload_task'

barbudor commented 1 year ago

fixed PR on the way