Closed gwenchee closed 5 years ago
Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
d3ploy/demand_driven_deployment_inst.py
:Line 133:80: E501 line too long (85 > 79 characters) Line 274:80: E501 line too long (81 > 79 characters)
d3ploy/supply_driven_deployment_inst.py
:Line 127:80: E501 line too long (85 > 79 characters) Line 129:80: E501 line too long (81 > 79 characters) Line 264:80: E501 line too long (81 > 79 characters)
tests/integration_tests/buffer_test.py
:Line 466:80: E501 line too long (81 > 79 characters) Line 580:80: E501 line too long (81 > 79 characters) Line 581:80: E501 line too long (82 > 79 characters) Line 582:80: E501 line too long (80 > 79 characters) Line 622:80: E501 line too long (90 > 79 characters) Line 623:80: E501 line too long (93 > 79 characters) Line 673:80: E501 line too long (90 > 79 characters) Line 674:80: E501 line too long (93 > 79 characters) Line 675:80: E501 line too long (88 > 79 characters) Line 676:80: E501 line too long (86 > 79 characters)
The code looks good. I guess my only concern is the style.
p0.2 / n1000
This type of entry seems like it's open to error, but I also understand the limitations we are facing. I'll think about it for a bit and if I can't think of anything I'll merge it in.
Yeah i thought about it too, another way is to add other state variable of a boolean for perceentage (False), number (True) but thats just another input variable to worry about.
I updated this PR by adding a new state variable for defining buffer type, @FlanFlanagan @robfairh
This PR addresses https://github.com/arfc/d3ploy/issues/240